Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] use chronos test fixture in smoke tests #4056

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

canerturkmen
Copy link
Contributor

@canerturkmen canerturkmen commented Apr 6, 2024

Issue #, if available:

Description of changes:

Previously time series smoke tests and model tests did not reuse the hf_model_path test fixture, leading to about ~250 downloads on Hugging Face for each CI run. This PR brings the number to about 10 40.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@canerturkmen canerturkmen added the module: timeseries related to the timeseries module label Apr 6, 2024
@canerturkmen canerturkmen added this to the 1.1 Release milestone Apr 6, 2024
@canerturkmen canerturkmen requested a review from shchur April 6, 2024 10:38
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 6, 2024

Previous CI Run Current CI Run

@yinweisu
Copy link
Collaborator

yinweisu commented Apr 6, 2024

Previous CI Run Current CI Run

Copy link

github-actions bot commented Apr 6, 2024

Job PR-4056-99ba5f2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4056/99ba5f2/index.html

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only some minor questions

timeseries/tests/unittests/models/test_models.py Outdated Show resolved Hide resolved
@yinweisu
Copy link
Collaborator

yinweisu commented Apr 8, 2024

Previous CI Run Current CI Run

Copy link

github-actions bot commented Apr 8, 2024

Job PR-4056-e29c924 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4056/e29c924/index.html

@canerturkmen canerturkmen merged commit d5062a1 into autogluon:master Apr 8, 2024
29 checks passed
@canerturkmen canerturkmen deleted the use-chronos-testfixture branch April 8, 2024 12:51
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: timeseries related to the timeseries module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants