Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Raise ValueError if duplicate feature names are provided for feature importance #4087

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

shchur
Copy link
Collaborator

@shchur shchur commented Apr 11, 2024

Description of changes:

  • If there are duplicate column names in static features & covariates, predictor.feature_importance() will fail 100% of the time with an uninformative error message. This PR raises an informative exception in this case.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 🎉

Copy link

Job PR-4087-a0e5824 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4087/a0e5824/index.html

@shchur shchur merged commit 40d9018 into autogluon:master Apr 11, 2024
29 checks passed
@shchur shchur deleted the feature-imporance-exception branch April 11, 2024 19:29
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants