Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tabular] Remove unnecessary duplicate call to _validate_calibrate_decision_threshold #4145

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

rey-allan
Copy link
Contributor

Issue #, if available:

Description of changes:

  • We are validating the calibrate_decision_threshold inside fit (L974). And then calling the validation function again inside _post_fit.
  • Since fit calls _post_fit, there's no need to call the validation function again.
  • This won't improve much, but the duplicated call is unnecessary.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rey-allan rey-allan added the code cleanup Fixing warnings/deprecations/syntax/etc. label Apr 26, 2024
@rey-allan rey-allan requested a review from Innixma April 26, 2024 00:20
@yinweisu
Copy link
Collaborator

Previous CI Run Current CI Run
fastcore==1.5.29 fastcore==1.5.31
fastcore==1.5.29 fastcore==1.5.31

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@Innixma Innixma merged commit a529105 into autogluon:master Apr 26, 2024
16 checks passed
Copy link

Job PR-4145-0751132 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4145/0751132/index.html

LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Fixing warnings/deprecations/syntax/etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants