Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contrib (second try) #17

Merged
merged 7 commits into from
Oct 10, 2020
Merged

Refactor contrib (second try) #17

merged 7 commits into from
Oct 10, 2020

Conversation

apiad
Copy link
Contributor

@apiad apiad commented Oct 10, 2020

No description provided.

@apiad apiad added enhancement New feature or request hacktoberfest2020 labels Oct 10, 2020
@apiad
Copy link
Contributor Author

apiad commented Oct 10, 2020

Hey @AnshuTrivedi I made this new pull request. If this works, I'll close the other. This will also count towards Hacktoberfest because it contains your commits.

@apiad apiad linked an issue Oct 10, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #17 into main will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   17.21%   17.17%   -0.05%     
==========================================
  Files          72       72              
  Lines        6946     6945       -1     
==========================================
- Hits         1196     1193       -3     
- Misses       5750     5752       +2     
Impacted Files Coverage Δ
autogoal/ml/__init__.py 100.00% <ø> (ø)
autogoal/ml/_automl.py 87.35% <0.00%> (-1.15%) ⬇️
autogoal/ml/_metalearning.py 36.69% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126ddde...cd862b1. Read the comment docs.

@apiad
Copy link
Contributor Author

apiad commented Oct 10, 2020

🚀 It works!!! Now it's time for @sestevez to accept the merge request, and that's it!

@sestevez sestevez merged commit af944ec into main Oct 10, 2020
@sestevez sestevez deleted the feature/refactor-contrib branch October 10, 2020 16:27
@apiad apiad linked an issue Oct 10, 2020 that may be closed by this pull request
@apiad
Copy link
Contributor Author

apiad commented Oct 14, 2020

@all-contributors add @AnshuTrivedi for code

@allcontributors
Copy link
Contributor

@apiad

I've put up a pull request to add @AnshuTrivedi! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor dependencies Refactor unit-testing for all contrib imports
4 participants