Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinction between left and right modifier keys #603

Closed

Conversation

sebastiansam55
Copy link
Contributor

WIP, like others have noted there are some major backend issues with making the distinction between the left and right shift.

@josephj11
Copy link
Contributor

Could <shift> and the others be made to default to the left or right variant so that (most) old scripts would still work?
If someone has remapped one of the shift keys on their keyboard, this might cause them problems, but that should just be documented.

@BlueDrink9
Copy link
Collaborator

I looked into rebasing this onto develop, but the single commit is too huge. I'll ask you to do it yourself I'm afraid.

@rbreaves
Copy link

This is a very worthy inclusion, I have a large set of complicated remaps that only work with this sort of distinction setup.. I believe I can now make use of this project!

@sebastiansam55
Copy link
Contributor Author

big changes related to this coming very soon, will be on a different commit!

@josephj11
Copy link
Contributor

Cool!!

How will this be exposed in the Record Hotkey dialog? I assume that it should somehow default to the current behavior of left and right ones being identical. Maybe a checkbox could be added to disinguish between left and right variants when the keys are subsequently pressed.

@sebastiansam55
Copy link
Contributor Author

see #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants