Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gtk): select cloned item #604

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(gtk): select cloned item #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ Features
---------
Create a GUI-free headless entrypoint to autokey, which can be run without GUI libraries and controlled purely via scripting API

.. Bug fixes
.. ---------
Bug fixes
---------
- Fix selection when cloning a phrase or script

Version 0.96.0-beta.9
============================
Expand Down Expand Up @@ -142,7 +143,7 @@ Bug fixes
- Both QT and GTK versions will reload hotkeys after a keymap change event.
- Fix locking issue
- Expose Alt_GR as a hotkey modifier on GTK.
- (GTK) Fixed GUI lock-up, if multiple script error notifications are posted in quick succession. The notifications are now rate-limited and won’t post more than one notification per second. Fixes issue #383
- (GTK) Fixed GUI lock-up, if multiple script error notifications are posted in quick succession. The notifications are now rate-limited and won’t post more than one notification per second. Fixes issue #383
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace change. Ideally we wouldn't have trailing whitespace in the first place, but it is usually considered annoying to open PRs that change whitespace in areas that aren't related to your change.

(Only a small PR so doesn't make a big difference in this case, but keep it in mind. Editor tools sometimes do this automatically, so review your diffs)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dang it, this must have been introduced in the rebase. I can remove the change, so I will.


Scripting API
+++++++++++++
Expand Down
3 changes: 3 additions & 0 deletions lib/autokey/gtkui/configwindow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,6 +1196,9 @@ def on_clone_item(self, widget, data=None):

self.app.monitor.unsuspend()
newIter = theModel.append_item(newObj, parentIter)
self.treeView.get_selection().unselect_all()
self.treeView.get_selection().select_iter(newIter)
self.on_tree_selection_changed(self.treeView)
self.app.config_altered(False)

def on_delete_item(self, widget, data=None):
Expand Down