Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the bug.yaml file to bug.yml on the develop branch. #901

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Rename the bug.yaml file to bug.yml on the develop branch. #901

merged 2 commits into from
Aug 8, 2023

Conversation

Elliria
Copy link
Contributor

@Elliria Elliria commented Aug 8, 2023

  • Rename the bug.yaml file to bug.yml.
  • Update the CHANGELOG.rst file:
    • Add the Other changes heading to the Version Develop section.
    • Note the renaming of the bug.yaml file to bug.yml.

* Add the **Other changes** heading to the **Version Develop** section.
* Note the renaming of the `bug.yaml` file to `bug.yml`.
@josephj11 josephj11 merged commit b4aab6d into autokey:develop Aug 8, 2023
6 checks passed
@josephj11
Copy link
Contributor

Merged and saw that it worked as intended.

@Elliria
Copy link
Contributor Author

Elliria commented Aug 9, 2023

This PR didn't actually change anything, because the action uses the files on the master branch to do its thing. It just brought the name of this file (the one on the develop branch) into compliance. The fix to the issue template was done two days ago on the master branch in PR #899 and PR #900 that BlueDrink merged in.

This file (the one on develop) is about to get another edit to make its contents identical to those in its counterpart on the master branch. This branch will also get a copy of the new config.yml file that the master branch just got.

My reason for doing these changes is that the develop branch is considered to be more modern than the master branch, so if a file is missing or different or only present on the develop branch, it's likely to (and probably should) be assumed that the state of the file on the develop branch is the desired and new-and-improved state for that file and its state on the master branch can be discarded when it comes time for the next release. To that end, anything that we've added to or changed or taken away from master that's desired should also be done to develop.

Anyway, those two PRs will be next.

@josephj11
Copy link
Contributor

I thought it was something like that. It did prove that the renamed file still works.

@Elliria
Copy link
Contributor Author

Elliria commented Aug 10, 2023

Yeah. I actually tried it out in my dummy repository first and it worked perfectly there. Then, when I did it here on the master branch and it didn't work, I was worried for a moment that there must have been something I overlooked. Then I realized, to my chagrin, that I had somehow added white-space on both sides of the single command in the file I had created, breaking the file. Luckily, that was a quick fix to remove and it solved the problem. Live and learn.

@josephj11
Copy link
Contributor

No white-space privilege allowed here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants