db: recreate projects with the same name #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daabr
reviewed
May 21, 2024
There was a problem hiding this comment.
The code is fine, but I don't see why we should allow this to happen.
This will allow situations where I refer to a project without knowing that it was deleted and replaced by another project.
Other than simple confusion, this is also an opening for abuse and attacks.
|
yes i am not a fan of this approach. will need to brainstorm another solution. |
itayd
approved these changes
May 22, 2024
ig-ra
force-pushed
the
igor/eng-871-recreate-projects-with-the-same-name
branch
from
d1f8002
to
8d3cb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow to recreate project with the same name.