Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide annotations from viewFeedback if it has not been released #1292

Merged
merged 1 commit into from Mar 19, 2021

Conversation

fanpu
Copy link
Contributor

@fanpu fanpu commented Mar 14, 2021

Description

Students, please do not look at this PR as it details an info-leak bug.

Go away now!


There is a bug where students can view unreleased annotations via the viewFeedback page for autograding feedback:

DeepinScreenshot_select-area_20210314153425

This PR fixes the bug by adding a check that grades have been released before showing annotations:

DeepinScreenshot_select-area_20210314153457

Motivation and Context

Bug fix

How Has This Been Tested?

  1. Create hello lab, add Style problem
  2. Student submits, gets autograded score
  3. Instructor adds annotations on style
  4. Student clicks on autograded score to go to viewFeedback page, sees Remarks with annotation text at the bottom. Able to determine style score based on this. Students can see style even before the instructors have decided to release all grades.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Copy link
Contributor

@oliverli oliverli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fanpu fanpu merged commit 585e531 into master Mar 19, 2021
@fanpu fanpu deleted the viewfeedback-hide-unreleased-annotations branch March 19, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants