Show hidden file in speedgrader #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,8 +25,7 @@ def self.get_files(archive_path) | |||
| header_position: i, | |||
| mac_bs_file: pathname.include?("__MACOSX") || | |||
There was a problem hiding this comment.
Not related to your changes but "__MACOSX" is a folder not a file. Therefore, it still appears in the speedgrader.
There was a problem hiding this comment.
Just to make sure, does it mean we don't want to display any folders in the archive that contains "__MACOSX"?
There was a problem hiding this comment.
Yup. That's a folder that mac creates when someone archives something.
There was a problem hiding this comment.
Cool I'll submit another PR to fix this soon!
|
LGTM. I think they called it "mac_bs_file" because of all the extra files macs make :/ also can we make a separate task for the "__MACOSX" folder issue? |
amartinez116
approved these changes
Apr 25, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #1166.
Motivation and Context
The current master does not support showing hidden files whose file name starts with a period, which could be problematic for some instructors. This is now enabled.
(To whoever reviews this PR: But can I know why hidden files are also considered mac_bs_file in the archive library? What does the term mean in the first place? 馃槀 )
How Has This Been Tested?
Submit an archive file with a hidden file in it. It should now appear alright in the speedgrader.
Types of changes
Checklist:
Other issues / help required
If unsure, feel free to submit first and we'll help you along.