Fix Gradesheet Scrolling Issue #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleyzhang
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a instructor wants to find student #200, they would have to scroll all the way down multiple times, because only 40 students are loaded at the start, and 20 each time. They are not able to do a CTRL-F to skip straight to a particular student number.
Description
This fix just ups the limit of students being shown at once to a 1000, which should be a good limit for most classes.
Motivation and Context
It is an issue our team found during our interviews with Angela from 15-122.
How Has This Been Tested?
Tested locally.
Types of changes
Checklist:
Other issues / help required
If unsure, feel free to submit first and we'll help you along.