Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Linting to Github actions #1489

Merged
merged 33 commits into from Apr 5, 2022
Merged

Adds Linting to Github actions #1489

merged 33 commits into from Apr 5, 2022

Conversation

victorhuangwq
Copy link
Contributor

Description

Runs rubocop as part of github workflow

Motivation and Context

To prevent users from bypassing the need to lint

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

Other issues / help required

If unsure, feel free to submit first and we'll help you along.

Copy link
Contributor

@Huahan98 Huahan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked GitHub Actions log, LGTM!

@victorhuangwq victorhuangwq merged commit 4e7d523 into master Apr 5, 2022
@victorhuangwq victorhuangwq deleted the victorhuangwq-patch-2 branch April 5, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants