Force download of attachments #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanpu
force-pushed
the
force-attachment-dl
branch
from
46fc0cc
to
5ab8eb5
Compare
Gemfile
Outdated
| @@ -119,7 +119,6 @@ group :development do | |||
| gem 'binding_of_caller' # enhances better_errors | |||
|
|
|||
| # static code analyzer | |||
| gem 'rubocop', require: false | |||
There was a problem hiding this comment.
you might have accidentally removed rubocop from the gemfile
xinyis991105
requested changes
Apr 6, 2022
fanpu
force-pushed
the
force-attachment-dl
branch
from
b54838d
to
20cc546
Compare
Restored the old Gemfiles, previously I was able to have rubocop working with just rubocop-rails and so thought it superseded rubocop |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cause attachments to be downloaded instead of being opened with the default MIME handler.
I had to also fix the rubocop-rails dependency in the Gemfile.lock as the previous config broke rubocop for me.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for lintingOther issues / help required
If unsure, feel free to submit first and we'll help you along.