Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix application xss #1520

Merged
merged 1 commit into from May 13, 2022
Merged

Fix application xss #1520

merged 1 commit into from May 13, 2022

Conversation

damianhxy
Copy link
Member

@damianhxy damianhxy commented May 13, 2022 •
edited

Description

  • Remove unnecessary raw tag

Motivation and Context

  • Currently, application name is xss-able

How Has This Been Tested?

  • Go to /oauth/applications
  • Create application with name <img src=a onerror=alert(document.cookie)>
  • Click on authorize, name should be correctly escaped

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting
  • My change requires a change to the documentation, which is located at Autolab Docs
  • I have updated the documentation accordingly, included in this PR

@damianhxy damianhxy requested a review from 20wildmanj May 13, 2022 01:48
20wildmanj
20wildmanj approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@20wildmanj 20wildmanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that escaping works as expected, LGTM!

@damianhxy damianhxy merged commit a0a2412 into master May 13, 2022
@damianhxy damianhxy deleted the fix-application-xss branch May 13, 2022 22:54
@damianhxy damianhxy mentioned this pull request Jul 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20wildmanj 20wildmanj 20wildmanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@damianhxy @20wildmanj