Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for DST for late days calculation #939

Merged
merged 1 commit into from Dec 4, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/submission.rb
Expand Up @@ -523,8 +523,8 @@ def days_late!
# check if no due at (due to infinite extension)
return 0 unless aud.due_at

# how late is the submission?
late_by = created_at - aud.due_at
# how late is the submission? (account for DST by offsetting difference in utc_offset)
late_by = created_at - aud.due_at + (created_at.utc_offset - aud.due_at.utc_offset);
return 0 if late_by <= 0

# if you're 2.5 days late, you're 3 days late
Expand Down