Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated types #358

Merged
merged 4 commits into from Jun 13, 2018
Merged

Updated types #358

merged 4 commits into from Jun 13, 2018

Conversation

hassankhan
Copy link
Contributor

@hassankhan hassankhan commented May 16, 2018 •
edited

  • Make filter parameter optional in Scan.consistent()
  • Allow RawSchemaAttributeDefinition to have properties of both type SchemaAttributeDefinition and RawSchemaAttributeDefinition
  • Allow dynamoose.model() constructor to accept Schema or SchemaAttributes

@coveralls
Copy link

coveralls commented May 16, 2018 •
edited

Coverage Status

Coverage remained the same at 82.495% when pulling 11e932d on hassankhan:patch-3 into 310da5c on automategreen:master.

@hassankhan hassankhan changed the title Make filter parameter optional in Scan.consistent() Updated types May 16, 2018
fishcharlie
fishcharlie approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fishcharlie fishcharlie added this to the v0.9.0 milestone May 17, 2018
@ecwyne
Copy link

ecwyne commented May 17, 2018

Might be worth updating the overwrite description while updating dynamoose.d.ts?

#359

@hassankhan hassankhan mentioned this pull request May 18, 2018
Closed
@hassankhan
Update dynamoose.d.ts
11e932d 
Fix `batch*()` methods to accept `KeySchema[]`
@fishcharlie fishcharlie modified the milestones: v0.9.0, v1.0 Jun 13, 2018
@fishcharlie fishcharlie merged commit 6a8f888 into dynamoose:master Jun 13, 2018
@fishcharlie fishcharlie mentioned this pull request Jun 13, 2018
Merged
@fishcharlie fishcharlie added this to the v1.0 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishcharlie fishcharlie fishcharlie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hassankhan @coveralls @ecwyne @fishcharlie