-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
982 omdbiapi key problems present as http 404 error in logs #1039
982 omdbiapi key problems present as http 404 error in logs #1039
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Should this error present to the UI as a notification? |
It could be, this was more to just correct the behaviour. As errors should be in the logfile anyway. Currently it only ends up in the log file if it's a debugging log. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…-ripping-machine to v2.6.70@c4d9f18 by renovate (#17753) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.69` -> `2.6.70` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.70`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.70) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.69...2.6.70) #### What's Changed - 1036 wrong changed date log creation timestamps in webui by [@​1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1040 - 982 omdbiapi key problems present as http 404 error in logs by [@​1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1039 - Bump arm-dependencies from `c3b0745` to `58ea158` by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1043 - Various Bugfixes for ARM by [@​microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#1025 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.69...2.6.70 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTYuNCIsInVwZGF0ZWRJblZlciI6IjM3LjE1Ni40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
…-ripping-machine to v2.6.70@c4d9f18 by renovate (truecharts#17753) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.69` -> `2.6.70` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.70`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.70) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.69...2.6.70) #### What's Changed - 1036 wrong changed date log creation timestamps in webui by [@&truecharts#8203;1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1040 - 982 omdbiapi key problems present as http 404 error in logs by [@&truecharts#8203;1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1039 - Bump arm-dependencies from `c3b0745` to `58ea158` by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1043 - Various Bugfixes for ARM by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#1025 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.69...2.6.70 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTYuNCIsInVwZGF0ZWRJblZlciI6IjM3LjE1Ni40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Description
Changes to allow logging of error messages from omdbapi to default logging type
Fixes #982
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.
Checklist:
Changelog:
Include the details of changes made here
Logs
Attach logs from successful test runs here