Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

982 omdbiapi key problems present as http 404 error in logs #1039

Conversation

1337-server
Copy link
Member

Description

Changes to allow logging of error messages from omdbapi to default logging type

Fixes #982

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

  • Docker
  • Other (Please state here)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made here

  • Changed logging of error messages from type debug to error

Logs

Attach logs from successful test runs here

github-actions bot and others added 3 commits January 20, 2024 07:30
Will now correctly log and error when connection to omdbapi
@1337-server 1337-server linked an issue Jan 20, 2024 that may be closed by this pull request
4 tasks
Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@1337-server 1337-server added the Bugfix Bugfixes in PR label Jan 20, 2024
@microtechno9000
Copy link
Collaborator

Should this error present to the UI as a notification?

@1337-server
Copy link
Member Author

It could be, this was more to just correct the behaviour. As errors should be in the logfile anyway. Currently it only ends up in the log file if it's a debugging log.

Copy link
Collaborator

@microtechno9000 microtechno9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@microtechno9000 microtechno9000 merged commit a335cf3 into main Jan 20, 2024
10 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jan 29, 2024
…-ripping-machine to v2.6.70@c4d9f18 by renovate (#17753)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine)
| patch | `2.6.69` -> `2.6.70` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>automatic-ripping-machine/automatic-ripping-machine
(automaticrippingmachine/automatic-ripping-machine)</summary>

###
[`v2.6.70`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.70)

[Compare
Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.69...2.6.70)

#### What's Changed

- 1036 wrong changed date log creation timestamps in webui by
[@&#8203;1337-server](https://togithub.com/1337-server) in
[automatic-ripping-machine/automatic-ripping-machine#1040
- 982 omdbiapi key problems present as http 404 error in logs by
[@&#8203;1337-server](https://togithub.com/1337-server) in
[automatic-ripping-machine/automatic-ripping-machine#1039
- Bump arm-dependencies from `c3b0745` to `58ea158` by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#1043
- Various Bugfixes for ARM by
[@&#8203;microtechno9000](https://togithub.com/microtechno9000) in
[automatic-ripping-machine/automatic-ripping-machine#1025

**Full Changelog**:
automatic-ripping-machine/automatic-ripping-machine@2.6.69...2.6.70

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTYuNCIsInVwZGF0ZWRJblZlciI6IjM3LjE1Ni40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
GabrielBarzen pushed a commit to GabrielBarzen/charts that referenced this pull request Feb 2, 2024
…-ripping-machine to v2.6.70@c4d9f18 by renovate (truecharts#17753)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine)
| patch | `2.6.69` -> `2.6.70` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>automatic-ripping-machine/automatic-ripping-machine
(automaticrippingmachine/automatic-ripping-machine)</summary>

###
[`v2.6.70`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.70)

[Compare
Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.69...2.6.70)

#### What's Changed

- 1036 wrong changed date log creation timestamps in webui by
[@&truecharts#8203;1337-server](https://togithub.com/1337-server) in
[automatic-ripping-machine/automatic-ripping-machine#1040
- 982 omdbiapi key problems present as http 404 error in logs by
[@&truecharts#8203;1337-server](https://togithub.com/1337-server) in
[automatic-ripping-machine/automatic-ripping-machine#1039
- Bump arm-dependencies from `c3b0745` to `58ea158` by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#1043
- Various Bugfixes for ARM by
[@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in
[automatic-ripping-machine/automatic-ripping-machine#1025

**Full Changelog**:
automatic-ripping-machine/automatic-ripping-machine@2.6.69...2.6.70

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTYuNCIsInVwZGF0ZWRJblZlciI6IjM3LjE1Ni40IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Bugfixes in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 OMDBIAPI Key Problems Present as HTTP 404 Error In Logs
2 participants