Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix UI missing none image, Apprise Errors and Version Increment Workflow path config #1079

Merged

Conversation

microtechno9000
Copy link
Collaborator

@microtechno9000 microtechno9000 commented Mar 12, 2024

Description

Fixes #1063
bugfix to code, changed none.jpg to none.png, there is no .jpg in the project.
workflow improvement, stop version increment workflow from running when a PR is raised to only modify the wiki

Fixes #1082
bugfix to the apprise notification code, catching for when job is not set. Amended UI to provide additional information on setting up and configuring apprise. Updated the wiki to align with apprise implementation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made

  • changes captured in file modifications

Logs

see below image
Screenshot_20240312_221333

Apprise logs not attached, error was repeatable when apprise notification sent with 'NOTIFY_JOBID' set to true. Confirmed error no longer present with bugfix

@microtechno9000 microtechno9000 changed the title Bugfix UI missing none image and Version Increment Workflow path config Bugfix UI missing none image, Apprise Errors and Version Increment Workflow path config Mar 17, 2024
Copy link

sonarcloud bot commented Mar 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shitwolfymakes
Copy link
Member

Great work!

@shitwolfymakes shitwolfymakes merged commit d26a1f1 into automatic-ripping-machine:main Mar 18, 2024
9 of 10 checks passed
@microtechno9000 microtechno9000 deleted the bugfix_ui branch March 19, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test apprise: 'str' object has no attribute 'job_id' Missing /static/img/none.jpg in docker image
2 participants