New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix permissions issue caused by a8a8b8f #1125
Conversation
@SylvainMT This will fix your issue once merged and released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the fix, seems the removal of chown to resolve a specific issue was not worth the general hassle.
Can you amend the wiki to explain that the default behaviour sets the user ARM as the owner using chown.
There are users that have mounted the ARM folders via a samba or NFS share that this will cause issues. Need to make sure those users are aware and mounting network shares is not the preferred config.
I see what you mean now. The way this is fixing the permissions issue will break permissions for shares every time it boots. I'll figure out a different way to fix this. |
Without this change, every time a user runs the container it will reset the permissions of the folders. Otherwise this could break ownership of arm folders mounted from SMB/NFS shares every time the container is run.
Quality Gate passedIssues Measures |
@SylvainMT This will no longer automatically fix your issue. If you are not using an external share for the container, running this should fix the permissions issues:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good with the proposed changes, best of both worlds
I also agree, that permissions need only be set at folder creation, not every time the container starts. Thanks for looking into the issue :) |
Description
Fixed an issue created by removing permissions setting in commit a8a8b8f. Confirmed working after running the rebuilt container.
The wiki now includes a note about default permissions for newly created folders and how that make affects users on mounting file shares
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: