Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

783 rip longest title #886

Merged
merged 7 commits into from
Jul 15, 2023
Merged

783 rip longest title #886

merged 7 commits into from
Jul 15, 2023

Conversation

1337-server
Copy link
Member

@1337-server 1337-server commented Jul 9, 2023

Description

Adding function to allow Blu-rays to only rip main feature. Instead of ripping everything and then deleting everything but the main feature.
This makes ripping with Blu-rays much faster when using the mainfeature setting.

Fixes #783

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Docker
  • Other (Bare-metal)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made here

  • Adds a new test/function to find the largest length title on the disc
  • Uses the new length to only rip titles of that length and skip the rest

Logs

Still testing for docker ATM... will add them all later

@1337-server 1337-server added the enhancement New feature request/PR label Jul 9, 2023
@1337-server 1337-server linked an issue Jul 9, 2023 that may be closed by this pull request
2 tasks
@1337-server
Copy link
Member Author

Capture

Just to show the difference in speed with this PR is applied, right is before, left is after.

@sonarcloud
Copy link

sonarcloud bot commented Jul 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1337-server
Copy link
Member Author

Using mkv as ripmethod: FAST_MKV.log
Using backup as ripmethod: FAST_backup.log

Ready for review

@1337-server 1337-server marked this pull request as ready for review July 13, 2023 23:02
@shitwolfymakes shitwolfymakes merged commit cca7809 into main Jul 15, 2023
2 checks passed
@shitwolfymakes shitwolfymakes deleted the 783-rip-longest-title branch July 15, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request/PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🔧 rip longest title
2 participants