Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcards not populated in hires prompt when using hires fix #37

Open
collinwalther opened this issue Jan 15, 2024 · 0 comments
Open

Wildcards not populated in hires prompt when using hires fix #37

collinwalther opened this issue Jan 15, 2024 · 0 comments

Comments

@collinwalther
Copy link

collinwalther commented Jan 15, 2024

Hires prompts are not properly modified to remove __wildcard__ tokens. Stepping through the debugger in sample_hr_pass in processing.py in the main stable-diffusion repo, I see that a number of hires-related prompt variables do not have the wildcards properly replaced: at least self.all_hr_prompts, self.hr_prompts, and self.hr_prompt. Anecdotally, this explains why all of my generations look decent on the first txt2img pass, but become very same-y after the hires pass.

I have to assume this was broken a long time ago when the base repo introduced the ability to set a different prompt for the hires pass AUTOMATIC1111/stable-diffusion-webui@ff0e171

The dynamic prompts extension had to put in a fix for this, so I assume it's also needed here adieyal/sd-dynamic-prompts#474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant