Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - (Windows) Absolute path not correctly recognized as such in aas_desc_outputs #278

Closed
AljenU opened this issue Nov 5, 2021 · 0 comments · Fixed by #291
Closed

BUG - (Windows) Absolute path not correctly recognized as such in aas_desc_outputs #278

AljenU opened this issue Nov 5, 2021 · 0 comments · Fixed by #291
Labels

Comments

@AljenU
Copy link
Collaborator

AljenU commented Nov 5, 2021

Determining whether a path is an absolute path is currently mostly done by checking whether the first character of the path is a forward slash. On windows, this is not a correct way for identifying an absolute path. There, such a path starts with a drive letter.

Add a function to determine whether a path is absolute or not.

Notes:
To be very safe, would need to go to something like https://nl.mathworks.com/matlabcentral/fileexchange/28249-getfullpath
For now, something inspired by https://svn.oss.deltares.nl/repos/openearthtools/trunk/matlab/general/io_fun/abspath.m will probably do good enough

@AljenU AljenU added the bug label Nov 5, 2021
@AljenU AljenU changed the title BUG - (Windows) Absolute paths not correctly recognized as such BUG - (Windows) Absolute path not correctly recognized as such in aas_desc_outputs Nov 10, 2021
AljenU added a commit to AljenU/automaticanalysis that referenced this issue Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant