Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP - modulenames #221

Merged
merged 2 commits into from Apr 22, 2021
Merged

Conversation

tiborauer
Copy link
Member

No description provided.

@tiborauer tiborauer added question cleanup Reducing clutter or ambiguity labels Feb 12, 2021
@tiborauer
Copy link
Member Author

Considering the lack of criticism as approval, I am going to merge this PR by the end of the week.

@ethanknights
Copy link
Contributor

Sounds good I think

The renaming of modules will lead to lots of manual cosmetic changes to old tasklist.xml files (e.g. Cam-CAN used a bunch of roi extraction modules throughout multiple streams for its different releases) but that's not a major issue, and I support adopting a more structured naming scheme (I am assuming these module names are more consistent than before!).

As for deleting modules. I didn't see these listed in Cam-CAN's latest tasklist, so that shouldn't cause a compatibility problem for us (perhaps they are old WIP modules anyway(?)):

aa_modules/aamod_coreg_structural2template.m
aa_modules/aamod_coregisterstructural2template.m #dupe?

@tiborauer
Copy link
Member Author

tiborauer commented Mar 24, 2021

Thanks, @ethanknights, so you are saying it is good to go?
Also, can you, please, take care of the "manual cosmetic changes" in the CBU examples?

Copy link
Collaborator

@jones-michael-s jones-michael-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tiborauer
Copy link
Member Author

Thank you, @jones-michael-s. I am going to merge now.

@tiborauer tiborauer merged commit 7e60165 into automaticanalysis:master Apr 22, 2021
@tiborauer tiborauer deleted the modulenames branch May 5, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Reducing clutter or ambiguity question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants