-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for apb catalog relist
#79
Conversation
Fixes #56 |
@dymurray what do I need to do to make this work? I tried this:
|
Added more detailed error messages and suggested actions: relist attempt without a bearer token
relist attempt without privileges to view routes
|
@dymurray in |
Short: "apb is a tool to manage ServiceBundle images", | ||
Long: `ServiceBundles are images that represent lifecycle components | ||
in that they contain all of the orchestration logic to manage | ||
Short: "apb is a tool to manage Ansible Playbook Bundle images", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really related to your PR, but the long summary here feels overly detailed to be in the bare apb
command help-text. Think we should consider stripping this down to just the short version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be good to get this ported over to client-go so that we don't need a bearer token in the future, but works well enough for now since it's equivalent to previous tool.
$ apb catalog relist --name ansible-service-broker
Successfully relisted OpenShift Service Catalog for [ansible-service-broker]
Includes small error check for current-context gathering.
Note: I would like to come back to this to use the dynamic go client to grab these resources but this is clean for now.