New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add postgres integration #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @shehabghazy! I'm submitting some remarks in advance while reviewing the remaining part of the pull request.
packages/backend/src/apps/postgres/common/postgres-configuration.ts
Outdated
Show resolved
Hide resolved
4798d37
to
0e77e8f
Compare
@shehabghazy, I've rebased the branch against the Besides this, there are some places I'd like to test and refactor a bit. Therefore, I'm considering pushing some changes to your branch. As I see you allowed maintainers to edit the pull request, I presume it's fine by you. Otherwise, let me know. |
882a4e6
to
3aaa499
Compare
Hey @shehabghazy, I have pushed some commits over your contribution. Introducing interactive where clauses along with some rewording and refactoring. I've done some testing which seems fine so far. However, I have not tried all the where clause operators. I'll take another look at this pull request tomorrow. Until then, do you think you could give it a try and let me know if you notice anything off? |
hey @barinali hope you have got well, |
28e660b
to
a1bda3b
Compare
a1bda3b
to
b20e360
Compare
Here is an integration with postgreSQL db with 4 actions:
Also it is available to add any run-time configuration parameter to SET before executing the actions
The linked issue : #923