Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add postgres integration #1076

Merged
merged 9 commits into from May 15, 2023

Conversation

shehabghazy
Copy link
Contributor

@shehabghazy shehabghazy commented May 3, 2023

Here is an integration with postgreSQL db with 4 actions:

  • Execute any SQL normal queries
  • Insert
  • Update
  • Delete
    Also it is available to add any run-time configuration parameter to SET before executing the actions

The linked issue : #923

@shehabghazy shehabghazy mentioned this pull request May 3, 2023
Copy link
Member

@barinali barinali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @shehabghazy! I'm submitting some remarks in advance while reviewing the remaining part of the pull request.

packages/backend/src/apps/postgres/index.ts Outdated Show resolved Hide resolved
packages/backend/src/apps/postgres/index.ts Outdated Show resolved Hide resolved
packages/backend/src/apps/postgres/index.ts Outdated Show resolved Hide resolved
packages/backend/src/apps/postgres/auth/index.ts Outdated Show resolved Hide resolved
@barinali
Copy link
Member

barinali commented May 9, 2023

@shehabghazy, I've rebased the branch against the main branch as it was outdated. We follow the conventional commit messages in the Automatisch code repository. So, I'd appreciate it if you could rephrase your commit message to something like feat(postgresql): add auth and primitive actions.

Besides this, there are some places I'd like to test and refactor a bit. Therefore, I'm considering pushing some changes to your branch. As I see you allowed maintainers to edit the pull request, I presume it's fine by you. Otherwise, let me know.

@barinali barinali force-pushed the postgres-integration branch 2 times, most recently from 882a4e6 to 3aaa499 Compare May 9, 2023 20:36
@barinali
Copy link
Member

barinali commented May 9, 2023

Hey @shehabghazy, I have pushed some commits over your contribution. Introducing interactive where clauses along with some rewording and refactoring. I've done some testing which seems fine so far. However, I have not tried all the where clause operators. I'll take another look at this pull request tomorrow. Until then, do you think you could give it a try and let me know if you notice anything off?

@shehabghazy
Copy link
Contributor Author

hey @barinali hope you have got well,
I apreciate your effort to enhance Automatisch, I have looked at your commits and the parts that you have applied some refactoring on, and it is very good to enhance it like this.. of cource I will inform you if I faced any problema while testing

@barinali barinali changed the title Add postgres integration feat: add postgres integration May 15, 2023
@barinali barinali merged commit 183b9b0 into automatisch:main May 15, 2023
1 check passed
@barinali barinali mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants