Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discord): add createEvent action #1450

Merged

Conversation

felifluid
Copy link
Contributor

Adds the functionality of creating events on a discord server.
This also implements a new dynamic-data to list voice and stage channels dynamically.

adds a helper function to provide dynamic data of voice and stage channels of a discord server
adds the action of creating a new event on a discord server. provides some sort of logic-check to make sure the correct fields have been filled, depending of the type given.
adds a simple entry in the docs for the createNewEvent action
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2023

CLA assistant check
All committers have signed the CLA.

@felifluid felifluid changed the title feature/discord-createEvent-action feat(discord): add createEvent action Nov 26, 2023
@barinali barinali self-requested a review November 27, 2023 14:04
@barinali
Copy link
Member

Thanks for the contribution, @felifluid! Once you help me with the open remark, I plan to do a minor iteration on your pull request and go ahead with that.

By the way, I have already tested it, and it works well. I appreciate your effort!

@barinali barinali force-pushed the feature/action-discord-create-event branch from eead974 to c98ac05 Compare November 27, 2023 17:01
@barinali
Copy link
Member

I've made some changes as below, @felifluid. I'll merge it once the pipeline succeeds. I'd appreciate it if you could test this and let me know if it's working as expected on your end.

  • introduced dynamic fields where we show some fields and they're conditionally required
  • renamed the action to align it more with Discord wording
  • removed the ineffective privacy_level field as it's always 2
  • transform argument keys to camel case for consistency

Thanks once again!

@barinali barinali merged commit 87866e3 into automatisch:main Nov 27, 2023
7 checks passed
@felifluid felifluid deleted the feature/action-discord-create-event branch November 27, 2023 22:24
@felifluid
Copy link
Contributor Author

I was really getting my head around how this dynamic fields work. Well, now I know! Thanks for making this so much prettier 😁
I will give it a test as soon as I get to it (:

@barinali
Copy link
Member

@felifluid I'll create a pull request to remove the new prefix from the name and the key in action, as it's redundant and also for consistency along with other actions.

This will cause mismatching data in your local in case you have already used this action. So, please keep in mind that you'll have to update the relevant steps in your flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants