Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unify react-query query keys #1804

Merged
merged 1 commit into from Apr 12, 2024
Merged

feat: unify react-query query keys #1804

merged 1 commit into from Apr 12, 2024

Conversation

kattoczko
Copy link
Collaborator

Pattern for creating a query key:

  • each part of the endpoint is a separate item in the query key array
  • params are passed as an object

This way searching for related queries is easier:
Zrzut ekranu 2024-04-12 093052

And query keys are unique:
Zrzut ekranu 2024-04-12 093441

@kattoczko kattoczko self-assigned this Apr 12, 2024
@barinali barinali merged commit 608b79b into main Apr 12, 2024
7 checks passed
@barinali barinali deleted the unify-query-keys branch April 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barinali barinali barinali approved these changes

@ridvanakca ridvanakca Awaiting requested review from ridvanakca

Assignees

@kattoczko kattoczko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kattoczko @barinali