Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move <title> markup to functions.php #12

Closed
obenland opened this issue Mar 22, 2012 · 4 comments
Closed

Move <title> markup to functions.php #12

obenland opened this issue Mar 22, 2012 · 4 comments

Comments

@obenland
Copy link
Member

From how I understand the WPTRT guideline on modifying the document title content, it would be best practice to filter 'wp_title' in functions.php and just have

<title><?php wp_title( /* optional params */ ); ?></title>

in header.php.

This would be a huge benefit for all SEO Plugins out there since they could easily modify the title and don't have to worry about stuff being added.

What do you say? :)

@ianstewart
Copy link
Contributor

I've been waiting for http://core.trac.wordpress.org/ticket/18548 to work itself out before moving on this but patches are welcome!

@obenland
Copy link
Member Author

Hm, where would such a 'wp_title' filter function be placed best?
In tweak.php, since it tweaks the default behavior of the wp_title() function?
Or rather in functions.php itself, to make sure to always have a title?

What do you think?

@ianstewart
Copy link
Contributor

Good question. I would probably put it in template-tags or functions.php

@crondeau
Copy link

Has any progress or change been made on this? I submitted a theme to the repo and it was rejected because of the <title>. The reviewer mentioned the following - Themes are required to modify output via filter (wp_title/body_class/post_class)

(http://themes.trac.wordpress.org/ticket/8447)

obenland added a commit that referenced this issue Nov 28, 2012
* Introduces a filter for wp_title instead of hard-coding things in header.php
* Renames inc/tweaks.php to inc/extras.php
* Includes inc/extras.php by default in functions.php

See #12, #13, #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants