action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() #94

tmtrademark · 2014-09-15T18:22:18Z

do_action() will never return a value, so having the flag is meaningless.

GaryJones · 2022-03-14T11:42:53Z

In the Ad_Code_Manager::shortcode(), there's a return $this->action_acm_tag( $id, false );, so it's this secondary use of the action_acm_tag() that the $echo parameter is being used for.

That said, I do think this could be refactored into a function that always returns the tag value (which can be called for the shortcode output), and a separate function which echo's the return from that first function (for the add_action() call).

- Extracts the logic for getting the output HTML into a new `get_acm_tag()` method. - The `action_acm_tag()` method now just echoes the result of a call to `get_acm_tag()`. It no longer supports an `$echo` parameter. - The `shortcode()` method now calls and returns `get_acm_tag()`, instead of `action_acm_tag()` with a `false` echo parameter. Closes #94.

GaryJones added the Type: maintenance label Mar 14, 2022

GaryJones added this to the 0.6 milestone Mar 14, 2022

GaryJones mentioned this issue Mar 17, 2022

Refactor action_acm_tag() #150

Merged

GaryJones closed this as completed in #150 Mar 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() #94

action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() #94

tmtrademark commented Sep 15, 2014

GaryJones commented Mar 14, 2022

action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() #94

action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() #94

Comments

tmtrademark commented Sep 15, 2014

GaryJones commented Mar 14, 2022