This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
[bugfix] calling get_article_style to apply the style filter #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everton-rosario
suggested changes
Feb 1, 2018
class-instant-articles-post.php
Outdated
| @@ -991,6 +991,10 @@ public function set_appearance_from_settings() { | |||
| $this->instant_article->withStyle( 'default' ); | |||
| } | |||
|
|
|||
| if (has_filter('instant_articles_style')) { | |||
There was a problem hiding this comment.
Its better to remove the method get_article_style() and call inline the apply_filters.
Also add a documentation block before this method call apply_filters
/**
* Apply the default filter 'instant_articles_style' for the instant article.
*
* @since 4.0.6
* @param string $template Path to the current (default) template.
* @param Instant_Article_Post $instant_article_post The instant article post.
*/
$article_style = apply_filters( 'instant_articles_style', 'default', $this );
if ( $article_style !== null && !Type::isTextEmpty( $article_style ) ) {
$instant_article->withStyle( $article_style );
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #864
It now correctly applies the filter style