Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional ad spots to theme #70

Closed
laurelfulford opened this issue Jul 5, 2019 · 0 comments · Fixed by #156
Closed

Add additional ad spots to theme #70

laurelfulford opened this issue Jul 5, 2019 · 0 comments · Fixed by #156
Labels
[Type] Core functionality Required core theme functionality

Comments

@laurelfulford
Copy link
Contributor

This issue is to track the potential need for additional ad spots in the Newspack theme:

There are spots ads can be added without editing the theme, like below the content and at the top and bottom of the sidebar.

Ads can also be added by using widgets, or added to the content area using block we're currently developing.

This leaves spaces outside of the content area, and dynamic pages like:

  • Archive pages - like category, tag, author, and custom post type archives; content is currently not editable, as it's all dynamically generated. Will have a widgetized sidebar.
  • Blog posts page - similar to the above, the page that shows all of the posts on a site. Content for the most part is not editable; since it is an actual page when not set to the front page, we can update the theme to output the_content before the posts are displayed, but can't edit the post output. Will have a widgetized sidebar.
  • Search results - content is currently not editable. Will have a widgetized sidebar.
  • 404 page - uses a template with static content; can't be edited via WordPress.
  • Image/attachment - all page content is dynamically generated, so can't be edited via WordPress.

... and the header and the footer.

For the dynamic pages, if we can't hook into things dynamically, we could manually add hooks to the theme.

For the header and footer, potential spots include above and below the header, and above the footer.

@laurelfulford laurelfulford added the [Type] Core functionality Required core theme functionality label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Core functionality Required core theme functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant