Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary separators in login #2724

Merged
merged 4 commits into from
Mar 23, 2021

Conversation

Klauswk
Copy link
Contributor

@Klauswk Klauswk commented Mar 8, 2021

Fix

While on login screen, a few separators were add unnecessary on File and Edit menu.

image

image

This changes fix these issue checking if the separator is necessary before adding.

image

image

Test

  1. Download the Windows and/or Linux builds from CircleCI.
  2. Go to login page.
  3. Check if the separators are correct.
  4. Login.
  5. Check if the addicional options are add.

Release

  • Fix unnecessary separators in the Electron builds File and Edit menus when not yet logged in.

Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for noticing this and submitting a PR to resolve it.
I've left one comment so far on the code.

desktop/menus/file-menu.js Outdated Show resolved Hide resolved
@codebykat codebykat modified the milestone: 2.9.0 Mar 19, 2021
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good and tests well.
Thanks again for submitting and making some changes along the way!

@sandymcfadden sandymcfadden added this to the 2.10.0 milestone Mar 23, 2021
@sandymcfadden sandymcfadden merged commit a682de6 into Automattic:develop Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants