Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add overflow to changes list section of unsynchronized confirmation dialog #2816

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 30, 2021

Fix

Fixes #2716

This PR adds overflow to the changes list section of the unsynchronized confirmation dialog, this will enable scroll if the list is too long while keeping the action buttons visible.

unsynchronized-dialog-overflow.mp4

Test

  1. Go offline to prevent saving notes.
  2. Create 10 or more notes.
  3. Make the window height as small as possible.
  4. Exit the application.
  5. Observe that the unsynchronized confirmation dialog displays all the content and that the changes list is scrollable.

Release

N/A

@fluiddot fluiddot added the bug Something isn't working label Mar 30, 2021
lib/dialog/style.scss Outdated Show resolved Hide resolved
@fluiddot fluiddot force-pushed the fix/unsynchronized-confirmation-dialog-long-list branch from f8165a4 to fdc809f Compare March 30, 2021 16:41
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes that the unsynced notes screen much nicer. Thank you.

I did leave a question on the related PR about the use of interpolation for the sass variable which is used here as well.

@fluiddot fluiddot force-pushed the fix/unsynchronized-confirmation-dialog-long-list branch from fdc809f to 3e9c8df Compare March 31, 2021 16:47
@fluiddot fluiddot added this to the 2.10.0 milestone Mar 31, 2021
@fluiddot fluiddot merged commit 29a6ca4 into develop Mar 31, 2021
@fluiddot fluiddot deleted the fix/unsynchronized-confirmation-dialog-long-list branch March 31, 2021 17:15
@fluiddot fluiddot self-assigned this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsynchronized notes warning needs a height and overflow
2 participants