Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove fixed height from tab panels #2834

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Apr 9, 2021

Fix

When navigating to Settings/Display the content was displaying two scroll bars, one set by the dialog content (introduced in this recent PR) and the other by the tab panels component due to having a fixed height.

Since the dialog component is already setting a max height, we don't really need to specify a fixed height in the tab panels so I removed that CSS propery.

Before After
Screenshot 2021-04-09 at 16 41 17 Screenshot 2021-04-09 at 16 41 28

Test

  1. Go to Settings
  2. Click on Display
  3. Observe that the content can be scrolled and that there's only one scroll bar

Release

N/A

@fluiddot fluiddot added the bug Something isn't working label Apr 9, 2021
@fluiddot fluiddot requested a review from a team April 9, 2021 14:42
@fluiddot fluiddot self-assigned this Apr 9, 2021
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call and catch, thank you!

@fluiddot fluiddot added this to the 2.10.0 milestone Apr 12, 2021
@fluiddot fluiddot merged commit 46cef33 into develop Apr 12, 2021
@fluiddot fluiddot deleted the fix/dialog-tab-panels-double-scroll branch April 12, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants