Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Set checkbox component isStandard prop optional #2843

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix: Set checkbox component isStandard prop optional #2843

merged 1 commit into from
Apr 13, 2021

Conversation

fluiddot
Copy link
Contributor

Fix

This PR introduced a Typescript error in RadioGroup component because it's not setting the isStandard prop when rendering the checkboxes. I changed this prop to be optional so by default it renders the circle variant.

Test

Standard checkboxes

  1. Open a note
  2. Click on actions button on the top-right corner
  3. Observe that standard checkboxes are displayed properly

Default checkboxes

  1. Open settings
  2. Click on Display
  3. Observe that default checkboxes are displayed properly

Release

N/A

@fluiddot fluiddot added the bug Something isn't working label Apr 13, 2021
@fluiddot fluiddot requested review from sandymcfadden and a team April 13, 2021 14:44
@fluiddot fluiddot self-assigned this Apr 13, 2021
sandymcfadden
sandymcfadden approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have caught this on the last PR, glad you caught it.

@fluiddot fluiddot added this to the 2.10.0 milestone Apr 13, 2021
@fluiddot fluiddot merged commit 99295a6 into develop Apr 13, 2021
@fluiddot fluiddot deleted the fix/checkbox-is-standard-optional branch April 13, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandymcfadden sandymcfadden sandymcfadden approved these changes

Assignees

@fluiddot fluiddot

Labels
bug Something isn't working
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fluiddot @sandymcfadden