Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the heights of a few dialogs to be larger then the default max-height #2863

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Update the heights of a few dialogs to be larger then the default max-height #2863

merged 2 commits into from
Apr 28, 2021

Conversation

sandymcfadden
Copy link
Contributor

@sandymcfadden sandymcfadden commented Apr 20, 2021 •
edited

Fix

Fixes #2859
Fixes #2861

There had been a max-height set for the default of all dialogs used. This turned out to be too small for a few dialogs.
This increases the height for the Keybindings, Settings, About, and Collaborate dialogs to better fit.

Before Screen Shot 2021-04-20 at 12 53 42 PM Screen Shot 2021-04-20 at 12 53 33 PM Screen Shot 2021-04-20 at 12 53 25 PM Screen Shot 2021-04-20 at 12 53 16 PM
After Screen Shot 2021-04-20 at 12 51 50 PM Screen Shot 2021-04-20 at 12 51 35 PM Screen Shot 2021-04-20 at 12 51 24 PM Screen Shot 2021-04-20 at 12 51 10 PM

Test

  1. Open About Dialog.
  2. Ensure the full content can be seen.
  3. Open the keyboard shortcuts help dialog.
  4. Ensure it is larger and can see more of the content.
  5. Open the Settings dialog.
  6. Ensure the first Account screen can all be seen.
  7. Open the Collaborate dialog for a note.
  8. Ensure it appears with increased size.

@sandymcfadden sandymcfadden added this to the 2.10.0 milestone Apr 20, 2021
@sandymcfadden sandymcfadden self-assigned this Apr 20, 2021
@sandymcfadden sandymcfadden force-pushed the fix/increase-select-dialog-heights branch 2 times, most recently from e8a01d8 to 6232a86 Compare April 20, 2021 16:37
@sandymcfadden sandymcfadden requested a review from a team April 20, 2021 16:37
@sandymcfadden sandymcfadden marked this pull request as ready for review April 20, 2021 16:38
This was linked to issues Apr 20, 2021
Multiple dialogs have decreased in height #2859
Closed
Account dialog scroll position is reset when Share Analytics is toggled #2861
Closed
belcherj
belcherj approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully, this will get a lot cleaner with the WordPress components.

@sandymcfadden sandymcfadden force-pushed the fix/increase-select-dialog-heights branch from 6232a86 to 952e582 Compare April 28, 2021 11:32
@sandymcfadden sandymcfadden merged commit f1a881e into release/2.10.0 Apr 28, 2021
@sandymcfadden sandymcfadden deleted the fix/increase-select-dialog-heights branch April 28, 2021 11:54
sandymcfadden added a commit that referenced this pull request Apr 28, 2021
@sandymcfadden
Update the heights of a few dialogs to be larger then the default max…
7a99264 
…-height (#2863)

Fixes #2859
Fixes #2861

There had been a max-height set for the default of all dialogs used. This turned out to be too small for a few dialogs.
This increases the height for the Keybindings, Settings, About, and Collaborate dialogs to better fit.
@sandymcfadden sandymcfadden mentioned this pull request Apr 28, 2021
Merged
sandymcfadden added a commit that referenced this pull request Apr 28, 2021
@sandymcfadden
Merge 2.10.0 beta 2 into develop (#2877)
1a88417 
There were a few hotfixes which went into 2.10.0 beta 2, this moves them back into develop.
See: #2867, #2863, #2862, and #2876.
This was referenced May 4, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
None yet
Milestone
2.10.0
3 participants
@sandymcfadden @belcherj @pachlava