Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing on tag list edit buttons #2893

Merged
merged 1 commit into from May 4, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

Fixes #2891

Currently, if you set to sort tags alphabetically and then choose to edit your tag list, the trash icon is hard up to the right side of the list.
If you have it set to manually sort tags then the reorder handle has spacing on the right.

This makes it more consistent and adds the spacing in either situation.

Before:
Screen Shot 2021-05-04 at 8 37 09 AM

After:
Screen Shot 2021-05-04 at 8 36 46 AM

Test

  1. Set tags to be sorted alphabetically
  2. Open tag list.
  3. Choose to edit tags.
  4. Notice trash icon is spaced nicely from the right.
  5. Set tags to be no longer sorted alphabetically.
  6. Choose to edit tags.
  7. Ensure spacing still looks correct.

Release

  • Fixed spacing issue on the trash tag button when set to sort tags alphabetically.

@sandymcfadden sandymcfadden added this to the 2.12.0 milestone May 4, 2021
@sandymcfadden sandymcfadden requested a review from a team May 4, 2021 11:40
@sandymcfadden sandymcfadden self-assigned this May 4, 2021
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sandymcfadden sandymcfadden merged commit 3fc1eab into develop May 4, 2021
@sandymcfadden sandymcfadden deleted the fix/tag-list-edit-button-spacing branch May 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Position of trash tag button feels off
2 participants