Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default title bar space for Mac Electron #2896

Merged
merged 3 commits into from May 5, 2021

Conversation

sandymcfadden
Copy link
Contributor

@sandymcfadden sandymcfadden commented May 4, 2021

Fix

Previously we had been adding specific styles to different components for only Mac Electron app to prevent things from overlapping the window buttons.

This removes those and instead enables the default title bar.

Screenshots Screen Shot 2021-05-04 at 1 55 54 PM Screen Shot 2021-05-04 at 1 55 40 PM

Test

  1. Run Mac Electron app.
  2. Ensure bar appears at the top with the app below it as usual.

Release

  • Added default title bar to Mac Electron app

@sandymcfadden sandymcfadden added this to the 2.12.0 milestone May 4, 2021
@sandymcfadden sandymcfadden requested a review from a team May 4, 2021 16:39
@sandymcfadden sandymcfadden self-assigned this May 4, 2021
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except:

  • note-toolbar/style.scss Line 22

It looks a little different. Can you get a review from Sly? We don't ship macOS so It is more of making him aware.

@sandymcfadden
Copy link
Contributor Author

Thanks, @belcherj I was so confused because while searching in my editor I couldn't find any more instances of is-macos. There wasn't any, but I hadn't saved that file after changing 🤦

@SylvesterWilmott
Copy link
Contributor

Looks good @sandymcfadden

Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship

@sandymcfadden sandymcfadden merged commit 3330c5b into develop May 5, 2021
@sandymcfadden sandymcfadden deleted the update/enable-titlebar-mac-electron branch May 5, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants