Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note list components to use CSS variables for colors #2969

Merged
merged 4 commits into from Aug 7, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This is a continuation of moving to CSS variables for colors within the app.
This updates the note list and related components

  • Note List
  • Note Cell
  • No Notes

It also fixes a small issue with the tag suggestions, but more will be required for that component in future PRs.
It also fixes an issue with the search highlighting in the note list where a background color was being set on matches when it shouldn't be.

Test

  • Smoke test in light and dark mode
  • Switch to All notes and ensure components look the same
  • Switch to a tag and ensure components look the same
  • Switch to the trash and ensure components look the same
  • Perform a search and ensure components look the same

Release

  • Updated the Note List, Note Cell, and No Notes, components to use CSS variables for colors

@sandymcfadden sandymcfadden added this to the 2.17.0 milestone Jul 30, 2021
@sandymcfadden sandymcfadden self-assigned this Jul 30, 2021
@sandymcfadden sandymcfadden marked this pull request as ready for review August 1, 2021 01:15
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I tested in the browser, light and dark modes, and didn't see any style differences between this branch and production.

@sandymcfadden sandymcfadden merged commit 54a23c5 into develop Aug 7, 2021
@sandymcfadden sandymcfadden deleted the update/note-list-components-css-variables branch August 7, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants