Add support to handle unverified accounts at login #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsakaimbo
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Looks good! Small nit: please add a comment around the order-of-priority for the password check vs. the unverified accounts, i.e. the user updating their password will lead to automatic account verification (since the password update is routed through their email).
Otherwise changes are pretty similar to #2972 and seem pretty straightforward.
Update node-simperium dependancy to latest Fix logic error in login error handling Add support for failed login due to unverified account Fix typo in error message Update error message
sandymcfadden
force-pushed
the
add/account-verification-check-login
branch
from
052461e
to
19e9051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This will add support to show an error message with a link to start verification of account email when logging in with an unverified account.
Todo
Test
This is rather hard to test currently to see the new error message as changes to the API endpoint haven't been made to show the error yet.
We can ensure that login still works as expected that you can log in with a valid email and password, and you can't log in with an invalid one.
In order to test this, I had to set up Charles Proxy and use it to intercept the API call and change the response text to be
verification requiredRelease