Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated navigation bar and tag list components to use css variables for colors #3018

Merged
merged 2 commits into from Sep 29, 2021
Merged

Updated navigation bar and tag list components to use css variables for colors #3018

merged 2 commits into from Sep 29, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This is a continuation of moving to CSS variables for colors within the app.
This updates the Navigation Bar and Tag List components.

Test

  • Smoke test in light and dark mode
  • Click the menu icon in the upper left to open the navigation bar
  • Compare between production and this branch
  • Ensure the navigation bar panel looks the same
  • Click the edit button in the tag list
  • Ensure the icons still look the same

Release

  • Updated the Navigation Bar and Tag List components to use CSS variables for colors

@sandymcfadden sandymcfadden added this to the 2.21.0 milestone Sep 26, 2021
@sandymcfadden sandymcfadden self-assigned this Sep 26, 2021
@sandymcfadden sandymcfadden added this to In progress in New CSS Architecture Sep 26, 2021
belcherj
belcherj approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 :shipit:

@sandymcfadden sandymcfadden merged commit b21d7e6 into develop Sep 29, 2021
@sandymcfadden sandymcfadden deleted the update/navigation-bar-tag-list-components-css branch September 29, 2021 07:28
@sandymcfadden sandymcfadden moved this from In progress to Done in New CSS Architecture Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

@codebykat codebykat Awaiting requested review from codebykat

Assignees

@sandymcfadden sandymcfadden

Labels
None yet
Projects
New CSS Architecture
Done
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sandymcfadden @belcherj