Dara: Featured Image srcset issue

[laurelfulford]

Originally reported by @senff in 4348-wpcom-themes:

The Featured Image on the home page is being cropped inconsistently. On page load it is cropped, but when switching to iPad view, and then back to normal view, it is not cropped anymore. Even after a refresh, it stays uncropped.

Steps to replicate

1. Go here: ​https://jswbaileylaw.com/

2. The Featured Image is a bit cropped (you can not see the boats at the bottom of the image, first screenshot). Refreshing the page will not change this.

3. Open the inspector into iPad view. The boats are now visible at the bottom (second screenshot)

4. Close inspector panel. The window is back to the original size, but now the boats are visible. Refreshing the page will "reset" that (third screenshot)

5. Open the site again in a new tab. Now the boats are gone again even though the window is the exact same size as the other tab.

Testing

I tried to replicate this on a test site, but I can not seem to reproduce it. So I'm not sure if it's a bug or just a quirky edge case. Also, it only appears on Chrome/Windows, no issues on Mac.

• User report: 3037275-t
• User's site: https://jswbaileylaw.com/

[laurelfulford]

After investigating, @sixhours had the following comments:

... the correct image with the appropriate crop for that page is here: ​https://jswbaileylaw.files.wordpress.com/2017/01/0221-annapolis-2.jpg?w=1180&h=435&crop=1

This is reflected in the theme's post thumbnail size for this page:

// Full-width and grid page template
add_image_size( 'dara-page-thumbnail', 1180, 435, true );

For me (Chrome on Mac), the image is first shown un-cropped, then is cropped properly after loading the Inspector.

I don't know why the image is showing un-cropped at any given time. There's nothing in the theme that's changing the crop of the image save for the declared thumbnail size above. I'm noticing the same thing happens on the user's site when testing Sela (via Theme Butler), which tells me this isn't a theme-specific issue.

We've had some luck with users re-uploading the image in question when Photon quirks like this pop up. Please have the user try that.

[sixhours]

I'm inclined to wontfix this; it's a bit of an edge case (happens after a window resize) and is fixed by a refresh. The theme's code is working as intended, and it's not specific to Dara.

[alaczek]

I'm for wontfixing this one as well.

[sixhours]

I can't reproduce this any more, either. Wontfixing.