Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typography support #22

Closed
ingeniumed opened this issue Aug 11, 2023 · 1 comment · Fixed by #24
Closed

Add typography support #22

ingeniumed opened this issue Aug 11, 2023 · 1 comment · Fixed by #24
Assignees
@ingeniumed

Comments

@ingeniumed
Copy link
Contributor

Typography properties are not supported in the plugin and we need to fix that.
@ingeniumed
Copy link
Contributor Author

ingeniumed commented Aug 11, 2023 •
edited

Removing theme as the base level parameter like is the case for all other styles makes it show up in the palette. It's not applied because the CSS generation is skipped as it's missing the theme base parameter. If I return the same CSS as what Gutenberg expects, that breaks the editor.

I suspect the theme parameter is the key here, and we need to tweak that. Perhaps typography expects something like default or custom instead.

@ingeniumed ingeniumed self-assigned this Aug 21, 2023
@ingeniumed ingeniumed mentioned this issue Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ingeniumed ingeniumed

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ingeniumed