-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications - Unseen notifications marked as seen #88344
Comments
@fullofcaffeine I see you are the most recent contributor to the apps/notifications readme, if you might have any ideas about the above or who to ping. We have the post request for /notifications/seen going out when it shouldn't be. I tried building calypso dev, sync'd the notes build to my sandbox, sandboxed widgets, etc. and have been trying to test around this, but this is weird. I only see 1 place that calls to sendLastSeenTime which seems is responsible for that post request, but I don't see it called when debugging locally. I can see the I feel like im missing some steps in getting the development environment for this setup correctly. |
It seems like there is something related to sandboxing the selected site? This is a really weird end of day find, as it doesn't seem to make any sense but also is consistent in testing.
As soon as i unsandbox the selected site URL, the issue comes back. Similarly, if I remove the sync'd app build from my sandbox the issue comes back as well, even though that sync'd build had no actual code changes. The part about the selected site is WEIRD - but it does fit with my initial findings above regarding the discrepency between test |
A clarifying Update! Im finding that the problem within calypso is due to notifications from within the site preview. This explains why my local debugging in calypso wasnt working, and explains the discrepency between So the problem seems to be within the standalone section of the notes app. I was focusing deeper inside the Panel section since that is all that calypso uses and the bug was reproducible there. Important note - the problem isn't specifically that notes are loaded in site previews, this problem happens everywhere the standalone notes app is loaded. I will continue to investigate more. |
This should now be resolved with #88463 |
Related to slack thread p1709902592755159-slack-C06DN6QQVAQ
The Problem
Notifications are being marked as seen without being opened in a number of places. By "marked as seen" i do not mean "read", but i mean that the orange dot that displays when there are unseen notifications disappears.
To Repro
To repro, you will probably need to trigger some notifications. Getting a comment on one of your blogs should do this. You can probably do this in an incognito tab as a logged out user. If you have a sandbox you can run a wp_cli command for ease of use as described in p2XLIi-JB-p2
/me/notifications
, im not sure if this is necessary but i wanted to ensure no other systems were picking up the notifications in testing these isolated areas.Notes
So far this seems to happen everywhere we have notifications, except global state with the new nav sidebar (no idea why?). Here are some of my notes from testing different notification components in isolation:
A - /home in default view / simple site (old topbar in calypso)
B - in global sidebar (at /sites)
C - in wp-admin for a classic site (core masterbar)
D - P2
E - global sidebar at site level /home
F - network admin top bar
sometimes its after the first reload, sometimes after a few, but i cant seem to get it to happen with the new global sidebar when staying at the global level with no site selected.
The text was updated successfully, but these errors were encountered: