-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earn: update copy and icon on the Payments splash page in Earn. #43601
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~87 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
</div> | ||
<div> | ||
<Gridicon size={ 18 } icon="checkmark" /> | ||
{ this.props.translate( 'Collect payments in 135 countries.' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 20 times:
translate( 'Collect payments in 135 countries' )
ES Score: 14
</div> | ||
<div> | ||
<Gridicon size={ 18 } icon="checkmark" /> | ||
{ this.props.translate( 'Easily manage subscribers.' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 21 times:
translate( 'Easily manage subscribers' )
ES Score: 11
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3924242 Thank you @donlair for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far @donlair. Can we do a little CSS cleanup in this PR?
- The line length of the copy is really long now that the image we're using is smaller. Can we set a max width on the content area and then center the illustration in the remaining area?
Example at 66% width for the content (even this line length still feels pretty long but it's better):
-
Let's remove the left padding on the content div on larger viewports. The text is out of alignment with the heading elements above it.
-
On smaller viewports we should bump up the left and right padding to 16px to align with the rest of the elements.
-
The checklist could benefit from some wider line spacing. It feels a bit cramped. Also maybe less space between the checkmark and the text.
-
On mobile, the longer text on the checklist looks odd as the lines wrap under the checkmark. Can the text be indented and aligned with itself there with the checkmarks acting more like bullet points?
@danhauk could you take a look at the update? I added a Card component around the main content to get it closer to your updated comps. Does that also address your concerns around the heading / content alignment? I've also adjusted the spacing and wrapping on the list. |
</div> | ||
<p className="memberships__onboarding-paragraph"> | ||
{ this.props.translate( | ||
'WordPress.com Payments makes it easy to sell physical and digital goods, accept donations, charge for in-person services, build subscription newsletters, and more.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 9 times:
translate( 'WordPress.com Payments makes it easy to sell physical and digital goods, accept donations, charge for in-person services, build subscription newsletters, and more. One-time, monthly, and yearly credit and debit card payment options are supported.' )
ES Score: 8
<p className="memberships__onboarding-paragraph">{ cta }</p> | ||
<p className="memberships__onboarding-paragraph"> | ||
{ this.props.translate( | ||
'Payments are securely processed by Stripe, a payment partner for all credit and debit card payments.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 9 times:
translate( 'Payments are safely, securely, and seamlessly processed by Stripe, a payment partner for all credit and debit card payments. Stripe provides easy access to your money and takes just minutes to set up.' )
ES Score: 6
36e7c24
to
97dd0f4
Compare
@@ -498,7 +445,7 @@ class MembershipsSection extends Component { | |||
) } | |||
> | |||
<NoticeAction href={ `/earn/payments-plans/${ this.props.siteSlug }` } icon="create"> | |||
{ this.props.translate( 'Add a payment plan' ) } | |||
{ this.props.translate( 'Add a Payment Plan' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3924242 Thank you @donlair for including a screenshot in the description! This is really helpful for our translators. |
@donlair Thanks for working to bring it closer to the proposed design. I think it's looking good. I pushed up a couple commits to tweak the styles, add mobile styles, and use some typography variables we have available. Here's some screenshots: |
8065873
to
31b20c8
Compare
This change request became irrelevant after we switched to the updated design.
@danhauk I rebased the update and your changes look good to me. Can you mark this as reviewed? I'll deploy the changes once we get a green light that the name change updates are stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Translation for this Pull Request has now been finished. |
This PR updates the copy and icon used on the dedicated Payments page that is shown when who has not yet connected to Stripe clicks the Payments card link in the Earn section of Calypso. Context for the changes is at pbMlHh-i6-p2.
Here are screenshots showing the changes:
Before:
After:
Testing instructions