Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change concierge upsell offer with the new 30 minute duration #45670

Merged
merged 5 commits into from
Sep 29, 2020
Merged

Change concierge upsell offer with the new 30 minute duration #45670

merged 5 commits into from
Sep 29, 2020

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Sep 15, 2020 •
edited
Loading

Changes proposed in this Pull Request

More info: pbBQWj-kR#comment-1156-p2
This PR changes the hardcoded copy to match the new 30 minute duration of the Purchased Concierge session.
It uses a hardcode variable as we don't have access to the real duration until after purchasing a session.
There are 4 locations where this has been replaced:

/me/concierge booking

/me/purchases QS upsell banner

/checkout/offer-quickstart-session

/checkout/offer-support-session

Testing instructions

/me/concierge booking
  • Go to /me/concierge
  • Select a site with QS session
  • Fill in form and submit
  • Open any of the days and it should mention that the session has lasts 30mins

/me/purchases QS upsell banner
  • Make sure you have at least 1 QS session (included or purchased) - this is to make sure the proper banner appears
  • Go to /me/purchases
  • QS upsell banner should not mention the duration of the QS

/checkout/offer-quickstart-session
  • Make sure you have a site {SITE_NAME} without QS sessions
  • Go to /checkout/offer-quickstart-session?site={SITE_NAME}.wordpress.com
  • Content should mention 30 minute session

/checkout/offer-support-session
  • Make sure you have a site {SITE_NAME} without QS sessions
  • Go to /checkout/offer-support-session?site={SITE_NAME}.wordpress.com
  • Content should mention 30 minute session

@claudiucelfilip claudiucelfilip added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Sep 15, 2020
@claudiucelfilip claudiucelfilip self-assigned this Sep 15, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/30-min-paid-qs-sessions

@matticbot
Copy link
Contributor

matticbot commented Sep 15, 2020 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~12 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
checkout        +136 B  (+0.0%)      +28 B  (+0.0%)
concierge        -65 B  (-0.0%)      -16 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented Sep 15, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4407614

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 22, 2020 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4407614

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@claudiucelfilip claudiucelfilip requested a review from a team September 28, 2020 10:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 28, 2020
a8ci18n
a8ci18n reviewed Sep 28, 2020
View reviewed changes
client/me/purchases/concierge-banner/index.jsx
'Quick Start Session is a one-on-one video session between the user and our support staff.',
}
);
mainText = translate( 'Schedule your 1-1 Quick Start Session with a Happiness Engineer!', {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 19 times:
translate( 'Schedule your 45-minute 1-1 Quick Start Session with a Happiness Engineer!' ) ES Score: 7

travisw
travisw approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@travisw travisw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@travisw travisw added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 29, 2020
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 29, 2020
victorespigares
victorespigares approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@victorespigares victorespigares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@claudiucelfilip claudiucelfilip merged commit 0a0892b into master Sep 29, 2020
@claudiucelfilip claudiucelfilip deleted the update/30-min-paid-qs-sessions branch September 29, 2020 08:01
@matticbot matticbot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Sep 29, 2020
@a8ci18n
Copy link

a8ci18n commented Sep 29, 2020 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4407614

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 12, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8ci18n a8ci18n a8ci18n left review comments

@victorespigares victorespigares victorespigares approved these changes

@travisw travisw travisw approved these changes

Assignees

@claudiucelfilip claudiucelfilip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claudiucelfilip @matticbot @a8ci18n @victorespigares @travisw