adding more tracing detail on failure condition #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and didn't have everything that was expected in place, although we knew it all. attemptConnect() now sets what it needs as a side effect and only returns a Boolean (success/fail) indicator - it may not even need to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more tracing in WebSocket, and fixing a logic flaw (event flow issue) where relevant mutable state was known but not correctly set in place when external events could be triggered - specifically, inital sync on connecting to a peer can trigger concurrently with finishing setup such that the send() can't operate since the connection state isn't finished setting up. Re-ordered that flow so that state is set up completely before that signal is sent.
That signal could be sent outside of the attemptConnect() flow, but two places can potentially call this logic flow, so keeping it together and (unfortunately - as a side effect) seemed like a better way to collapse the detail to be able to reason about it. I changed up the return value from attemptConnect() so that it's a bit "less" of a pure function, but it's (more) obvious that it operates on context/state and updates it (a mutable function)