Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated global functions #128

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Remove deprecated global functions #128

merged 2 commits into from
Jul 13, 2023

Conversation

emschwartz
Copy link
Contributor

No description provided.

@emschwartz emschwartz requested a review from a team July 12, 2023 11:10
Copy link
Member

@mellowagain mellowagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't break anyone? maybe its fair to check direct dependents on crates.io and github to see if any of them still use it and maybe open a issue in the respective repos?

@emschwartz
Copy link
Contributor Author

@mellowagain it might, but everything that's going in now will be part of the 0.6 release and some of the other changes will break things as well (like changing the names of metrics means you'll need to update the dashboards). Nevertheless, good suggestion about checking public dependents and submitting PRs for them

@emschwartz
Copy link
Contributor Author

@mellowagain I just checked all of the crates that depend on this one. The ones that are still using the encode_global_metrics function are still on an earlier version, such as 0.3.3. I'm less worried about there being breaking changes if/when they decide to update if they're already a couple versions behind.

@emschwartz emschwartz merged commit 8a6c50d into main Jul 13, 2023
1 check passed
@emschwartz emschwartz deleted the remove-deprecated branch July 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants