Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customizing global Autometrics settings #130

Merged
merged 11 commits into from
Jul 26, 2023
Merged

Conversation

emschwartz
Copy link
Contributor

@emschwartz emschwartz commented Jul 13, 2023

  • Add AutometricsSettingsBuilder and enable setting custom histogram buckets
  • The custom-objective-latency feature is now compatible with more features
  • Initializing settings also initializes the prometheus_exporter (if the feature flag is enabled) to prevent you from initializing settings afterwards and causing them to not be picked up by the exporter

Resolves #117

@emschwartz emschwartz marked this pull request as ready for review July 17, 2023 08:56
@emschwartz emschwartz requested a review from a team July 17, 2023 08:57
@emschwartz emschwartz merged commit 7430e67 into main Jul 26, 2023
1 check passed
@emschwartz emschwartz deleted the global-settings branch July 26, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to configure global settings
2 participants