Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autometrics 1.0 compliance] add autometrics.version to build_info #154

Merged
merged 4 commits into from
Nov 13, 2023
Merged

[autometrics 1.0 compliance] add autometrics.version to build_info #154

merged 4 commits into from
Nov 13, 2023

Conversation

mellowagain
Copy link
Member

@mellowagain mellowagain commented Nov 13, 2023 •
edited

resolves AM-125

Checklist

  • Changelog updated

@mellowagain mellowagain requested a review from a team November 13, 2023 10:59
gagbo
gagbo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@gagbo gagbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the hardcoded value is the best idea since anyway it's only depending on the code in autometrics

@mellowagain mellowagain merged commit 4cfd2f3 into main Nov 13, 2023
1 check passed
@mellowagain mellowagain deleted the autometrics-version branch November 13, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagbo gagbo gagbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mellowagain @gagbo